Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change G_CODE for babysteping #919

Closed
Emented opened this issue Aug 19, 2020 · 12 comments · Fixed by #1043
Closed

Change G_CODE for babysteping #919

Emented opened this issue Aug 19, 2020 · 12 comments · Fixed by #1043
Labels
enhancement New feature or request
Projects

Comments

@Emented
Copy link

Emented commented Aug 19, 2020

Hello guys!
I've installed octodash andI really like it, but i use klipper and it has another comands for babystepping during a print(
So the question is, how ti change them, where are located files with this commands?

@Emented Emented added the support Something isn't working with the users setup label Aug 19, 2020
@dmiart
Copy link

dmiart commented Aug 19, 2020

this.printerService.executeGCode(`M290 Z${value}`);

I believe it's this one.

You might also be able to make a MCODE 290 macro. Not sure whether macros can accept input parameters though.

@Emented
Copy link
Author

Emented commented Aug 19, 2020

this.printerService.executeGCode(`M290 Z${value}`);

I believe it's this one.

You might also be able to make a MCODE 290 macro. Not sure whether macros can accept input parameters though.

So, how can I change this file on my PI?

@dmiart
Copy link

dmiart commented Aug 19, 2020

I am fairly new to this framework, but if I am not mistaken, all files are compressed inside /opt/OctoDash/resources/app.asar. However you can make your own debian package from source.

https://github.com/UnchartedBull/OctoDash/blob/master/CONTRIBUTING.md

@UnchartedBull
Copy link
Owner

Even if you'd manage to unpack it you probably won't find that line. Angular does a lot of magic before packaging everything (minifying, treeshaking and other optimizations), so this line won't look the same. Rebuilding everything is your best guess here. I can also add a config option to a later version, so users can define there baby-stepping commands, but that will take a while.

@UnchartedBull UnchartedBull added this to To do in v3 Release Aug 19, 2020
@Emented
Copy link
Author

Emented commented Aug 19, 2020

Even if you'd manage to unpack it you probably won't find that line. Angular does a lot of magic before packaging everything (minifying, treeshaking and other optimizations), so this line won't look the same. Rebuilding everything is your best guess here. I can also add a config option to a later version, so users can define there baby-stepping commands, but that will take a while.

I'm really new to all of this stuff, so I'l try to make a macro, and wait for the update, because I don't understand how to do it on my own)

@UnchartedBull UnchartedBull moved this from To do to In progress in v3 Release Aug 31, 2020
@stale
Copy link

stale bot commented Sep 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issue label Sep 13, 2020
@UnchartedBull UnchartedBull added enhancement New feature or request and removed stale Stale issue support Something isn't working with the users setup labels Sep 14, 2020
@whoim2
Copy link

whoim2 commented Sep 25, 2020

Good idea - configurable g-codes and titles for babystep screen. I want use klipper command "ajust", no absolute value, and my values (0.05, 0.01).

"executeGCode(M290 Z${value}); " is a absolute value? This broke my gcode_offset from cura start gcode section:
SET_GCODE_OFFSET Z=absolute_value

Klipper have non-absolute commands for add or decrease offset from current offset value.

SET_GCODE_OFFSET Z_ADJUST=, where adjust non absolute value, but offset correct.

@UnchartedBull
Copy link
Owner

Custom values probably won't be added but the next release should at least include the option to replace M290 Z with something different.

@whoim2
Copy link

whoim2 commented Sep 28, 2020

Custom values probably won't be added but the next release should at least include the option to replace M290 Z with something different.

Only one command? Relative variants not in plan?
For each button custom command

@UnchartedBull
Copy link
Owner

I won't have the time to implement a custom command for each of those buttons. Feel free to open a PR though :)

@whoim2
Copy link

whoim2 commented Sep 29, 2020

I won't have the time to implement a custom command for each of those buttons. Feel free to open a PR though :)

Teach me build your code on rpi or ubuntu?)

@UnchartedBull
Copy link
Owner

v3 Release automation moved this from In progress to Done Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v3 Release
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants