Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to prepare route for serialization. Uses Closure. #4

Open
hbody opened this issue Feb 28, 2016 · 2 comments
Open

Unable to prepare route for serialization. Uses Closure. #4

hbody opened this issue Feb 28, 2016 · 2 comments

Comments

@hbody
Copy link

hbody commented Feb 28, 2016

I can't use artisan route:cache because of this package generates closure routes (with function).
Better will be to generate controller routes, because of with this package unable to fully optimize website.

@FreedomKnight
Copy link
Member

It should generate routing path dynamically by its configures files.
We will try to let it can be optimized.

@youchenlee
Copy link
Member

reference: laravel/framework#7319 (comment)

Agree with @hbody and @FreedomKnight , we should prevent closure routes since fileapi should be optimized for performance.

BTW, a nginx/apache alias or cache to the storage/app/images folder is recommended for the best performance optimization, the GET API is not necessary to go through PHP.
For example, in nginx, setup fastcgi_cache for it.

This should be mentioned in README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants