Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependabot is now running against MetPy forked repos #1424

Closed
akrherz opened this issue Jul 27, 2020 · 4 comments
Closed

dependabot is now running against MetPy forked repos #1424

akrherz opened this issue Jul 27, 2020 · 4 comments
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Status: Upstream Needs work done in upstream project Type: Bug Something is not working like it should

Comments

@akrherz
Copy link
Contributor

akrherz commented Jul 27, 2020

FYI / unsure if upstream MetPy can fix this, but I just updated my MetPy forked repo and now dependabot is creating the same pull requests against my fork.

It is unclear to me if each forked repo owner needs to disable dependabot or MetPy can limit dependabot to only run on its repo and not the forks.
@akrherz akrherz added the Type: Bug Something is not working like it should label Jul 27, 2020
@jthielen jthielen added the Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) label Jul 27, 2020
@jthielen
Copy link
Collaborator

jthielen commented Jul 27, 2020 •
edited
Loading

Based on this dependabot/dependabot-core#2198 (comment), I think everyone's forks will need to be re-created if they get the Dependabot v2 bug?

Update: I observed the bug as well, so I deleted my fork of MetPy and re-forked it, and can now confirm that Dependabot is no longer running on my fork.

@dopplershift
Copy link
Member

Well crap. I'm sorry to hear that. I mean, we're better for the change, so it's overall good, but that's really annoying. Looks like there's nothing we can do about it. 😢

@akrherz
Copy link
Contributor Author

akrherz commented Jul 28, 2020

Amazing, indeed, the procedure worked.

  1. Delete the fork
  2. Create the fork again
  3. Observe that "Dependabot isn't enabled on forks by default" on Insights -> Dependency Graph -> Dependabot

Grumble, Grumble. I am fine with closing this ticket if you want.

@dopplershift
Copy link
Member

Closing out since there's nothing for us to do about it.

@dopplershift dopplershift added the Status: Upstream Needs work done in upstream project label Jul 28, 2020
@jthielen jthielen mentioned this issue Aug 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Status: Upstream Needs work done in upstream project Type: Bug Something is not working like it should
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akrherz @dopplershift @jthielen