Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using ._data from xarray #1835

Open
dopplershift opened this issue Apr 27, 2021 · 0 comments
Open

Fix using ._data from xarray #1835

dopplershift opened this issue Apr 27, 2021 · 0 comments
Labels
Area: Xarray Pertains to xarray integration Status: Upstream Needs work done in upstream project Type: Enhancement Enhancement to existing functionality

Comments

@dopplershift
Copy link
Member

As of #1832, we're relying on Variable._data to check whether the data underlying a DataArrray is already a Quantity--in order to avoid getting .data and the loading of otherwise lazy data that incurs. This is intended as a short-term bug fix and needs to be changed to use a public API that needs to be worked out with upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Xarray Pertains to xarray integration Status: Upstream Needs work done in upstream project Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant