Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect LFC with capping inversion #350

Closed
jrleeman opened this issue Mar 17, 2017 · 0 comments
Closed

Incorrect LFC with capping inversion #350

jrleeman opened this issue Mar 17, 2017 · 0 comments
Assignees
Labels
Area: Calc Pertains to calculations Type: Bug Something is not working like it should
Milestone

Comments

@jrleeman
Copy link
Contributor

When there is a capping inversion, the first intersection found by find_intersections is below a capping inversion - clearly not the LFC as @dopplershift pointed out when reviewing a tutorial. Need to add a flag on find_intersections to specify the sense of the sign change. Flag direction with options increasing, decreasing, and all (default).

@jrleeman jrleeman added Area: Calc Pertains to calculations Type: Bug Something is not working like it should labels Mar 17, 2017
@jrleeman jrleeman added this to the 0.5.0 milestone Mar 17, 2017
@jrleeman jrleeman self-assigned this Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Bug Something is not working like it should
Projects
None yet
Development

No branches or pull requests

1 participant