Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of no LFC #387

Closed
jrleeman opened this issue Apr 11, 2017 · 6 comments
Closed

Handling of no LFC #387

jrleeman opened this issue Apr 11, 2017 · 6 comments
Labels
Area: Calc Pertains to calculations
Milestone
0.5.1

Comments

@jrleeman
Copy link
Contributor

Currently when there is no LFC we return None, None. Is that the behavior we want to stick with? We could throw an exception.
@jrleeman jrleeman added the Area: Calc Pertains to calculations label Apr 11, 2017
@jrleeman jrleeman added this to the 0.5.1 Bugfix milestone Apr 11, 2017
@dopplershift
Copy link
Member

I'm leaning against an exception, since this isn't really an exceptional case, but I could be convinced otherwise. @kgoebber any thoughts on what you'd prefer when teaching?

We also should probably consider what happens if we did this on a 2D grid....

@jrleeman
Copy link
Contributor Author

So are you thinking staying with the current implementation?

@dopplershift
Copy link
Member

Now that I think about it, more likely to change to NaN or a masked array so that we handle the gridded data case.

@jrleeman
Copy link
Contributor Author

Given #395 I'm thinking this won't be in 0.5.1?

@dopplershift
Copy link
Member

Well, we could change this to nan in this release since that would be more consistent behavior going forward.

@jrleeman
Copy link
Contributor Author

Closed by #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Calc Pertains to calculations
Projects
None yet
Milestone
0.5.1
Development

No branches or pull requests
2 participants
@dopplershift @jrleeman