Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default calendar in cftime.date2num to None #206

Closed
jswhit opened this issue Nov 5, 2020 · 1 comment
Closed

Change default calendar in cftime.date2num to None #206

jswhit opened this issue Nov 5, 2020 · 1 comment

Comments

@jswhit
Copy link
Collaborator

jswhit commented Nov 5, 2020

The current default calendar is standard which may produce surprising results for users who expect that calendar associated with the input datetime instances to be used. PR #205 changes the default to None which causes date2num to use the calendar associated with the first input datetime instance by default.
@jswhit jswhit mentioned this issue Nov 10, 2020
Merged
@jswhit
Copy link
Collaborator Author

jswhit commented Nov 10, 2020

closed by PR #205

@jswhit jswhit closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jswhit