Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branch v4.6.3-dev-branch.wif] nc_test4/test_filter crashes when linked against libhdf5 1.10.4 built with debugging enabled. #1344

Closed
WardF opened this issue Feb 25, 2019 · 9 comments
Assignees

Comments

@WardF
Copy link
Member

WardF commented Feb 25, 2019

The test executable test_filter in the nc_test4 directory crashes when the underlying libhdf5 has been built with debugging turned on. The specific failure occurs at libhdf5/nc4hdf.c:1006, in the call to H5Dcreate2(). This function returns an error code.

The same code works fine when linked against libhdf5 1.10.4 built without debugging enabled.

@WardF WardF self-assigned this Feb 25, 2019
@WardF
Copy link
Member Author

WardF commented Feb 25, 2019

This crash is reproducible on both OSX and Ubuntu 18.04.

@edhartnett
Copy link
Contributor

When you say debugging you mean the -g option?

@DennisHeimbigner
Copy link
Collaborator

I assume he means the --enable-build-mode=debug flag to hdf5.
I ran the same config under Ubuntu 16.2 (with debug mode) and it seems to work
ok for me.

@WardF WardF changed the title nc_test4/test_filter crashes when linked against libhdf5 1.10.4 built with debugging enabled. [Branch v4.6.3-dev-branch.wif] nc_test4/test_filter crashes when linked against libhdf5 1.10.4 built with debugging enabled. Feb 25, 2019
@WardF
Copy link
Member Author

WardF commented Feb 25, 2019

Yes, as @DennisHeimbigner said; turning on debugging during configure via --enable-build-mode=debug. Debug vs. No Debug is only one axis of inquiry at this point, as I did add some fenceposting for some hdf5 functions introduced in 1.8.15. I'd like to avoid bumping the minimum required version unless absolutely unnecessary.

I've also amended the title of the issue to specify the branch where this is happening. It appears to have been introduced in the commit where I added the fenceposting. I feel like I'm overlooking some minor detail, so hopefully this will be easily fixed.

@WardF
Copy link
Member Author

WardF commented Feb 25, 2019

It seems to me the most obvious reason for the debug vs. no debug split boils down to compiler optimization; whatever bug was introduced/is occurring gets optimized out when debug info is turned off. That is my current theory, at least.

@WardF
Copy link
Member Author

WardF commented Feb 25, 2019

To highlight one important detail initially left out: this is on branch v4.6.3-dev-branch.wif.

@WardF
Copy link
Member Author

WardF commented Feb 25, 2019

Ah, I believe I may have it.

@t-b
Copy link
Contributor

t-b commented Feb 26, 2019

@WardF Are the CI test results available public?

@WardF
Copy link
Member Author

WardF commented Feb 26, 2019

@t-b yes, at cdash.unidata.ucar.edu

Thanks!

@WardF WardF closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants