Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h5_test/tst_h_rd_cmp can be combined with tst_h_wrt_cmp to eliminate dependency #681

Closed
edhartnett opened this issue Nov 23, 2017 · 1 comment · Fixed by #680
Closed

Comments

@edhartnett
Copy link
Contributor

The test file h5_test/tst_h_rd_cmp.c used the output from tst_h_wrt_cmp.c. This creates a dependency between the tests. These are short code files, so no need to have this test in two code files. The read test simply reads what the write test produces.

I will combine these tests and eliminate tst_h_rd_cmp.

@edhartnett
Copy link
Contributor Author

The reason this was not breaking any parallel builds is because tst_h_rd_cmp was not being run. In PR #680 I move the test code from tst_h_rd_cmp.c to tst_h_wrt_cmp.c, and eliminate tst_h_rd_cmp.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant