Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing for nc4type.c #701

Closed
edhartnett opened this issue Nov 30, 2017 · 2 comments
Closed

Better testing for nc4type.c #701

edhartnett opened this issue Nov 30, 2017 · 2 comments

Comments

@edhartnett
Copy link
Contributor

In libsrc4, nc4type.c is now tied for the lowest percentage of lines tested, at %60. A look at the code coverage shows that some tests can easily be added for this code:

  • No test at all for NC4_inq_type_equal().
  • Checks for bad inputs when adding types.
  • Checks for typesize of atomic types.
  • NC4_inq_enum_ident() only checked for some types.
  • NC4_put_vlen_element() is not run during testing.

I will take a look at improving this test coverage...

@edhartnett
Copy link
Contributor Author

With PR #780 test coverage goes up to %74. So good progress but more can be done.

@edhartnett
Copy link
Contributor Author

Many more tests merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant