Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nc_test/tst_open_cdf5.c does not include config.h #842

Closed
edhartnett opened this issue Feb 6, 2018 · 2 comments · Fixed by #844
Closed

nc_test/tst_open_cdf5.c does not include config.h #842

edhartnett opened this issue Feb 6, 2018 · 2 comments · Fixed by #844
Assignees
@WardF
Milestone
4.6.1

Comments

@edhartnett
Copy link
Contributor

All test files must include "config.h" as the first include file, so that all the correct build-dependent pre-processor macros are defined before any other file is included.
@WardF
Copy link
Member

WardF commented Feb 6, 2018

I'll add this in to the current PR I'm editing for Windows.

@WardF
Copy link
Member

WardF commented Feb 6, 2018

Rather, I'm editing to fix some windows things and will roll this in.

@WardF WardF added this to the 4.6.1 milestone Feb 6, 2018
@WardF WardF self-assigned this Feb 6, 2018
@WardF WardF mentioned this issue Feb 6, 2018
Merged
@WardF WardF closed this as completed in #844 Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
4.6.1
Development

Successfully merging a pull request may close this issue.

Batch EJH Pull requests Unidata/netcdf-c
2 participants
@WardF @edhartnett