Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Fix bad escape codes #256

Merged
merged 4 commits into from Nov 7, 2018
Merged

MNT: Fix bad escape codes #256

merged 4 commits into from Nov 7, 2018

Conversation

dopplershift
Copy link
Member

Need to use raw strings now for strings with things like \s, even though it isn't a valid escape code.

Need to use raw strings.
jrleeman
jrleeman previously approved these changes Nov 6, 2018
Copy link
Contributor

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

It's a transitive dependency from other packages in the stack, and
manually installing it is pulling in some weird versions of other stuff
right now.
@dopplershift
Copy link
Member Author

ping @jrleeman

Copy link
Contributor

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 😈

@jrleeman jrleeman merged commit 53fb0d8 into Unidata:master Nov 7, 2018
@dopplershift dopplershift deleted the flake8 branch November 7, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants