New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline import doesn't work #395
Comments
I came across the same issue. Import of pipeline got broken somewhere after 2.0.0. I have installed UV from latest develop (clean install, no DPUs). I imported the DPUs using create template from zip, frontend sucessfully created the DPU Templates, dialogs work (which proves that frontend can access the DPU jars and they work). However, when I then want to import the pipeline itself, all the DPUs in it are listed as missing, even though they are not. |
Note: In 2.0 release (April 2), this issue does not appear, so it was introduced later on. |
Can we create a test for the pipeline import to guard against regression bugs like this one? |
we have tested import in 2.0.2 released version and for us it works ( @Jan-Marcek to confirm). |
Have you tested import of pipelines from before 2.0.2 to 2.0.2 as well? |
@jakubklimek Please upload somewhere the problematic exported file from pre-2.0.2 UV version, we will test it. |
I tried it. It happens in version odn 1.0.1 and 1.0.2 frontend.log
|
Kuba was trying to import to empty database of pipelines, so there cannot be a problem with already existing pipeline |
based on @Jan-Marcek comment, 2.0.2 version of UV is working OK, it is something in develop branch only. |
When I change the name of pipeline@uv then I imported the pipeline successfully. |
Using the provided zip file, when I try to import DPU's, I get following errors in UV:
|
when I tried @jakubklimek's pipeline: http://opendata.cz/kuba/datacube2009.zip then I got.
|
Is it even possible to import those dpu on 2.0.2? |
@eea02 : This seems to be a problem with Java version - the DPUs were compiled under Java 8 |
@Jan-Marcek The pipeline which Jakub has problems with is using certain outdated DPUs - so you need to have library for backward compatibility with UV 1.X API - see: https://grips.semantic-web.at/pages/viewpage.action?pageId=59113485 |
Isn't this caused by the backward compatibility library? Did you tested import with only 2.X compliant DPUs? |
Probably not, as the issue was also reported by Jindrich, who was using DPUs 2.X. You can also try to reproduce the problem reported by @jindrichmynarz . I also asked @jakubklimek to provide simpler pipeline export which is not working |
@jindrichmynarz do you have a pipeline example that doesn't work? |
Meanwhile, I have updated to UV in ODN 1.0.2 and I can no longer reproduce the issue for the pipeline that couldn't be imported previously. Should I close the issue and reopen it in case I encounter a failing import example? |
This issue is probably valid but if it works in UV 2.0.2 (ODN 1.0.2) then we can isolate bug in some change in develop branch. |
I have tested it in develop branch and there was one bug introduced recently by merging pull requests, but this should not be connected with problems described in here. It was fixed (c582efb) and then I tested pipeline export / import and it worked as expected;
I could not reproduce the described problem, everything worked as expected |
I tried to import DPU templates from a pipeline, in which I have a template for t-sparqlUpdate. However, the template was not imported. The result log contained Context: I tried this in ODN 1.1.0. |
UnifiedViews supports only one version of DPU so it is avoided now to install another version. |
Thanks for clarifying. However, I think the import of DPU templates should work the same as the import of DPU instances. I.e. if there is a newer version of a DPU that is able to handle configuration from previous DPU versions, then the import of DPU instance works. In that case I think the import of DPU templates should work as well. |
@OskarStoffan please check above requirements if we have included this into user story in |
My point is that importing DPU template and DPU instance is technically the same: it is an import of the DPU configuration (without the DPU JAR-file). Hence, I think they should be handled the same way. |
Got the point, will think about that and update |
#521 should fix this problem as it includes:
Note: not sure it fixes all the problems mentioned in this issue |
@jindrichmynarz / @tomas-knap please comment if all is fixed what is expected or if there is still outstanding issue (lot of issues discussed) |
I will test #521 and finalize. Then @jindrichmynarz can retest his use case. |
If I should retest this, then it would be useful to have the test scenarios written down, so that it is clear what to test. |
Isn't test scenario defined in bug report? |
As you wrote previously, there are many scenarios discussed here, so it's not clear what to retest. |
I tested the export/import feature on the following scenarios:
It behaved correctly at the end in all these situations. Suggest to close when #521 is merged. |
Importing pipelines doesn't work as expected. Even if there are the exact same versions of DPUs in the UV instance that exported the pipeline and the UV instance that imports it, pipeline import fails with "It is not possible to import pipeline due to missing DPUs. Please install DPUs from table and then run import again."
For example, I have a pipeline that uses
uv-t-sparqlUpdate-2.0.4-SNAPSHOT.jar
anduv-t-tabular-2.1.1-SNAPSHOT.jar
. The exact same DPUs are available in both UV instance I export the pipeline from and the UV instance I import the pipeline to. Nevertheless, importing the pipeline fails.Tested on the UV version that comes with odn-simple 1.0.1 Debian package.
Related to #356.
The text was updated successfully, but these errors were encountered: