Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link opening is totally broken with touch/pen #2545

Closed
MarcAnt01 opened this issue Oct 17, 2021 · 10 comments
Closed

Link opening is totally broken with touch/pen #2545

MarcAnt01 opened this issue Oct 17, 2021 · 10 comments

Comments

@MarcAnt01
Copy link
Collaborator

Describe the bug
Link opening is totally broken with touch/pen since some updates. I can reproduce it from chat messages and group/chat description

To Reproduce
Steps to reproduce the behavior:

  1. Click on any link in a message from chat;
  2. Enjoy

Expected behavior
Open the link

Version Info

  • Unigram: 8.1.6659
  • Windows: 11 21H2
@FrayxRulez
Copy link
Collaborator

Report to Microsoft

@MarcAnt01
Copy link
Collaborator Author

Report to Microsoft

Well, if the issue is "Microsoft" please provide some helpful context and specify it's something related to the os/winui/uwp/whatever I cannot reach out to Microsoft and tell and say "Fela said it's your fault"

@FrayxRulez
Copy link
Collaborator

I have no clue and I don't care, I just know that's not Unigram fault and I'm not going to investigate into this.

@MarcAnt01
Copy link
Collaborator Author

I am a simple user who spent 5 minutes investigating this problem and opening this issue, also after other people complained about it. This affects in a crucial way touch users, since they cannot open a simple link and I don't understand why you are behaving in a so mad way for a simple report.

@FrayxRulez
Copy link
Collaborator

FrayxRulez commented Oct 17, 2021

I'm not behaving in a mad way, I'm just saying that's definitely not Unigram problem and some other users have confirmed that the problem appeared after a specific Windows 11 update.
As you're a UWP developer yourself you should know that UWP apps don't handle directly touch input in most scenarios and that click events are processed seamlessly by the operating system regardless from the source itself.
"Since some updates" is also completely meaningless, considering that just three updates have been released since June, and all of them were minor updates from the tech stack point of view.

@MarcAnt01
Copy link
Collaborator Author

I'm just saying that's definitely not Unigram problem and some other users have confirmed that the problem appeared after a specific Windows 11 update

This should've been the reply since the beginning. I'm in the beta channel and considering the short amount of Unigram updates, it makes more sense to think about Windows 11 rather than Unigram or WinUI, since I would've most likely reported the issue after the Unigram update.

@xperiandri
Copy link

Then we need to vote for my report https://aka.ms/AAf9ns8

@MarcAnt01
Copy link
Collaborator Author

This is a proper report instead microsoft/microsoft-ui-xaml#6513

@BreeceW
Copy link

BreeceW commented Dec 22, 2021

You can fix this bug by adding <x:Boolean x:Key="HyperlinkUnderlineVisible">True</x:Boolean> on top of the WinUI 2 styles.

@BreeceW
Copy link

BreeceW commented Mar 5, 2022

The other way to fix this is to set, when you create the Hyperlink inline, UnderlineStyle = UnderlineStyle.None. So you can easily fix the problem using either underline style without any changes to Windows or WinUI 2, all on your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants