Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incident details dialog/modal #93

Closed
lunkwill42 opened this issue Jul 2, 2020 · 3 comments
Closed

Incident details dialog/modal #93

lunkwill42 opened this issue Jul 2, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request task
Milestone

Comments

@lunkwill42
Copy link
Member

lunkwill42 commented Jul 2, 2020

Clicking on an Incident description in the incident list should open a modal showing fuller details of the incident. I.e. the modal should repeat the information from the incident table entry, but also "everything else" related to the Incident, such as:

  • A list/table summarizing the Incident's related Events.
  • A list of tags attached to the Incident.
    • Any tag value that can be parsed as an URL should be clickable.
  • An interface to add/edit/hyperlink the ticket url of the Incident.
@lunkwill42 lunkwill42 added this to To do in Argus Sprint #1 via automation Jul 2, 2020
@jorgenbele jorgenbele self-assigned this Jul 23, 2020
@ddabble ddabble removed this from To do in Argus Sprint #1 Aug 5, 2020
@ddabble ddabble added this to To do in Argus Sprint #2 via automation Aug 5, 2020
@ddabble ddabble moved this from To do to In progress in Argus Sprint #2 Aug 5, 2020
@jorgenbele jorgenbele moved this from In progress to Waiting on backend in Argus Sprint #2 Aug 5, 2020
@jorgenbele jorgenbele moved this from Waiting on backend to Done in Argus Sprint #2 Sep 14, 2020
@lunkwill42 lunkwill42 added the enhancement New feature or request label Sep 15, 2020
@lunkwill42
Copy link
Member Author

@jorgenbele I'd say this is all fixed, with one exception: The model hyperlinks the "details" URL, however, it hyperlinks the relative URL stored in the incident object - it doesn't construct the full, valid URL based on the source system's base url. We should really have this in time for Thursday's demo.

@lunkwill42
Copy link
Member Author

Making note of the fact that the incident source's base url is available inline in each Incident object:

[
  {
    "pk": 18,
    "start_time": "2020-09-14T17:06:49.983721+02:00",
    "end_time": "infinity",
    "source": {
      "pk": 1,
      "name": "testnav",
      "type": {
        "name": "nav"
      },
      "user": 2,
      "base_url": "http://localhost:9080/"
    },
    "source_incident_id": "199420",
    "details_url": "/search/event/199420",
    "description": "Link DOWN on A1 at example-sw.example.org (4.kx042)",
    "ticket_url": "",
    "tags": []
  }
]

@hmpf
Copy link
Contributor

hmpf commented Sep 28, 2020

The detail url sent from the backend is now absolute if Source.base_url exisdts. Closing this.

@hmpf hmpf closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task
Projects
No open projects
Development

No branches or pull requests

3 participants