Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph widget modifies graph interval to 24 hours, no matter what the URL says #321

Closed
jmbredal opened this issue Jan 17, 2017 · 3 comments
Closed

Comments

@jmbredal
Copy link
Collaborator

jmbredal commented Jan 17, 2017

It appears that under NAV 4.6, the Graph widget will always modify the time interval of graphs, even when the interval buttons are disabled.

If attempting to add a graph with a custom time interval of, say, 3 hours, the displayed graph will always be for the last 24h interval.


Imported from Launchpad using lp2gh.

@jmbredal
Copy link
Collaborator Author

(by john-m-bredal)
Fix here:
https://nav.uninett.no/hg/nav/rev/59196ae30fe7

@jmbredal
Copy link
Collaborator Author

(by john-m-bredal)
When the buttons for choosing an interval was introduced it also introduced a complexity in that you now have two ways of deciding the interval - either as parameters in the url or by clicking the buttons.

It now works like this:

  • If we have timeframe buttons use those for interval
  • If we don't have buttons use 'from'-parameter
  • If we have neither use default timeframe (which currently is 'day')

@jmbredal jmbredal added this to the 4.6.1 milestone Jan 17, 2017
@lunkwill42 lunkwill42 assigned lunkwill42 and unassigned lunkwill42 Jan 25, 2017
@lunkwill42 lunkwill42 added the bug label Jan 25, 2017
@jmbredal
Copy link
Collaborator Author

Translated changeset references:
https://nav.uninett.no/hg/nav/rev/59196ae30fe7: 6858b2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants