Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third Party Accounting Reference #393

Closed
CGantert345 opened this issue Nov 28, 2023 · 2 comments · Fixed by #394
Closed

Third Party Accounting Reference #393

CGantert345 opened this issue Nov 28, 2023 · 2 comments · Fixed by #394
Assignees
Labels
improvements New feature or request
Milestone

Comments

@CGantert345
Copy link
Contributor

CGantert345 commented Nov 28, 2023

In some cases the accounting for a bookedOfferPart is not done by the provider of the API but by the provider of the transport service of the booking part. E.g.

  • SNCF provides a combined booking with Eurostar, but Eurostar is billing this directly.

To allow a validation of the billing the bookedOfferPart needs to include a reference to the accounting company and a list of accountingIds that will be used by the accounting company in the accounting data to reference the bookedOfferPart. A list is needed as some accounting systems further detail the bookedOfferPart.

@CGantert345 CGantert345 added the improvements New feature or request label Nov 28, 2023
@CGantert345 CGantert345 added this to the 3.2.0 milestone Nov 28, 2023
@CGantert345 CGantert345 self-assigned this Nov 28, 2023
@CGantert345 CGantert345 linked a pull request Nov 28, 2023 that will close this issue
@ralfbayer-db
Copy link
Collaborator

As the Fee booking part does not inherit from the AbstractBookingPart it does not contain the AccountingRef. Suggest adding it to Fee as well.

@ralfbayer-db ralfbayer-db reopened this Jan 11, 2024
@ralfbayer-db
Copy link
Collaborator

  • rename the fields of the AccountingRef structure (accountingCompany --> company, accountingIds --> ids) and add the accountingRef to the Fee object. Clemens provides a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvements New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants