Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need single "soldProductId" on offer parts #408

Closed
ralfbayer-db opened this issue Dec 6, 2023 · 3 comments · Fixed by #458
Closed

Need single "soldProductId" on offer parts #408

ralfbayer-db opened this issue Dec 6, 2023 · 3 comments · Fixed by #458
Assignees
Labels
improvements New feature or request
Milestone

Comments

@ralfbayer-db
Copy link
Collaborator

We base some mappings on the product Id returned in an (e.g. admission)offerPart. However, with through fares (e.g. High Speed Train + Local Train), some providers return a list of product IDs for one admission. 

We would need a new attribute "soldProductId", which refers to a product id which contains the relevant parameters from a selling point of view (e.g. refund options etc.).

@ralfbayer-db ralfbayer-db added the improvements New feature or request label Dec 6, 2023
@ralfbayer-db ralfbayer-db added this to the 3.2.0 milestone Dec 6, 2023
@ralfbayer-db ralfbayer-db self-assigned this Dec 6, 2023
@ralfbayer-db
Copy link
Collaborator Author

Proposal to add "soldProductId" or "commercialProductId" to the OfferParts - parked until next week as some parties with interest were not present today.

@ralfbayer-db
Copy link
Collaborator Author

The "list of products" was introduced in order to facilitate admissions which have multiple, incompatible refund conditions, e.g. TGV and TER in France.

If that were the case within a single OfferPart, this would have to have conflicting refund conditions valid for the same (or overlapping) date ranges, where it is completely unclear how this should be interpreted by the consuming system. In these cases it would be much cleaner to use serial admission offer parts (e.g. one for the TGV part, and another one for the TER part). Then we could either completely get rid of the product list (and only have one product per offer part), or at least introcude a "commercial product id" which defines things like tariff used and conditions relevant to this offer part.

@ralfbayer-db
Copy link
Collaborator Author

We agreed on an attribute called "summaryProductId".

@ralfbayer-db ralfbayer-db linked a pull request Feb 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvements New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant