Setting correct Content-Type for PATCH requests in net\http\Request.

UnionOfRAD · Sep 18, 2012 · c49de93 · c49de93
1 parent d0491b6
commit c49de93
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/net/http/Request.php b/net/http/Request.php
@@ -230,7 +230,7 @@ public function to($format, array $options = array()) {
 			$data = $auth::encode($options['username'], $options['password'], $data);
 			$this->headers('Authorization', $auth::header($data));
 		}
-		if (in_array($options['method'], array('POST', 'PUT'))) {
+		if (in_array($options['method'], array('POST', 'PUT', 'PATCH'))) {
 			$media = $this->_classes['media'];
 			if ($type = $media::type($this->_type)) {
 				$this->headers('Content-Type', $type['content'][0]);

diff --git a/tests/cases/net/http/ServiceTest.php b/tests/cases/net/http/ServiceTest.php
@@ -261,6 +261,18 @@ public function testPatchMethod() {
 		$this->assertEqual('someData=someValue', $result->body());
 	}
 
+	public function testPatchWithJson() {
+		$http = new Service($this->_testConfig);
+		$response = $http->patch(
+			'some-path/stuff',
+			array('someData' => 'someValue'),
+			array('return' => 'response', 'type' => 'json')
+		);
+		$result = $http->last->request;
+		$this->assertEqual('{"someData":"someValue"}', $result->body());
+		$this->assertEqual('application/json', $result->headers['Content-Type']);
+	}
+
 	public function testMagicMethod() {
 		$http = new Service($this->_testConfig);
 		$response = $http->magic('some-path/stuff');