Let users influence the relationship mode in models #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, one other thing: maybe the default could get set in |
|
Refs issue #453. |
|
Anybody available to finalize this? It'd be great to get it in before the next release. |
|
@blainesch I guess you've been cleaning up branches. This PR still has some good code. We just couldn't get to it (I know it's about time...). Do you mind undoing the PR branch delete so this PR can be reopened? |
|
@DavidPersson I don't have a fork of lithium anymore, so it could get complicated. The "reopen" button is disabled. This sha1 is in the main repo now though due to the pr. Somebody could easily start from where I left off by checking out the sha1 or copy/pasting the patch file. |
|
I'll handle this. There sure is a way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
modecan be defined on the relationship or at runtime. Two tests.