Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Closures spacing #605

Closed
daschl opened this issue Aug 6, 2012 · 5 comments
Closed

QA: Closures spacing #605

daschl opened this issue Aug 6, 2012 · 5 comments
Assignees
Labels

Comments

@daschl
Copy link
Contributor

daschl commented Aug 6, 2012

Hi everyone,

our coding standard is awesome, but there is no reference to how closures are writen.

Do we define function() .. or function () as the standard? This came up while writing tests for li3_qa.

What do you think?

Personally, I like the latter aproach since it fits nicely with our spaces for control structures and typecasting approach.

@ghost ghost assigned daschl Aug 6, 2012
@djordje
Copy link
Contributor

djordje commented Aug 6, 2012

@daschl
Copy link
Contributor Author

daschl commented Aug 6, 2012

@djordje there are both approaches sprinkled through core and possibly framework and I believe there was never a strict rule set up (until now).

So this is more or less a voting decision that will then be added to both li3_quality and the standard itself!

@jails
Copy link
Contributor

jails commented Aug 6, 2012

imo function() seems to be more coherent according the current coding standard.

@djordje
Copy link
Contributor

djordje commented Aug 6, 2012

@jails +1

@daschl
Copy link
Contributor Author

daschl commented Aug 7, 2012

Since @nateabele is also for function() let's do it this way!

I'll take care of it.

@daschl daschl closed this as completed Aug 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants