QA: Closures spacing #605

Closed
daschl opened this Issue Aug 6, 2012 · 5 comments

Comments

Projects
None yet
3 participants
Member

daschl commented Aug 6, 2012

Hi everyone,

our coding standard is awesome, but there is no reference to how closures are writen.

Do we define function() .. or function () as the standard? This came up while writing tests for li3_qa.

What do you think?

Personally, I like the latter aproach since it fits nicely with our spaces for control structures and typecasting approach.

daschl was assigned Aug 6, 2012

Member

daschl commented Aug 6, 2012

@djordje there are both approaches sprinkled through core and possibly framework and I believe there was never a strict rule set up (until now).

So this is more or less a voting decision that will then be added to both li3_quality and the standard itself!

Contributor

jails commented Aug 6, 2012

imo function() seems to be more coherent according the current coding standard.

Contributor

djordje commented Aug 6, 2012

@jails +1

Member

daschl commented Aug 7, 2012

Since @nateabele is also for function() let's do it this way!

I'll take care of it.

daschl closed this Aug 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment