We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi everyone,
our coding standard is awesome, but there is no reference to how closures are writen.
Do we define function() .. or function () as the standard? This came up while writing tests for li3_qa.
function() ..
function ()
What do you think?
Personally, I like the latter aproach since it fits nicely with our spaces for control structures and typecasting approach.
The text was updated successfully, but these errors were encountered:
In framework it's function() https://github.com/UnionOfRAD/framework/blob/master/app/config/bootstrap/action.php
function()
Sorry, something went wrong.
@djordje there are both approaches sprinkled through core and possibly framework and I believe there was never a strict rule set up (until now).
core
framework
So this is more or less a voting decision that will then be added to both li3_quality and the standard itself!
imo function() seems to be more coherent according the current coding standard.
@jails +1
Since @nateabele is also for function() let's do it this way!
I'll take care of it.
daschl
No branches or pull requests
Hi everyone,
our coding standard is awesome, but there is no reference to how closures are writen.
Do we define
function() ..
orfunction ()
as the standard? This came up while writing tests for li3_qa.What do you think?
Personally, I like the latter aproach since it fits nicely with our spaces for control structures and typecasting approach.
The text was updated successfully, but these errors were encountered: