-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking on Approve USDT does nothing #1172
Comments
This is duplicate of #1034 Unfortunately you must approve 0 for the Uniswap v2 router because USDT approves fail if the existing approval is non-zero |
I think that there should be a button in the interface to do this (call Approve with 0) or there should be a popup message with instructions saying what needs to be done and how. I'm a programmer and it is not immediately clear to me where I should first find the correct Uniswap v2 router address, then where do I find the correct USDT ERC20 contract address, then how to call Approve() on the USDT ERC20 contract using Etherscan and pass the Uniswap v2 router address as one of the parameters. If it's not clear to technical people, I'd wager it's impossible for non-technical people and it's very likely many people struggle with this. |
OK so if anyone ends up here via Google, here is what to do: The contract address of USDT ERC20 is: Go to the USDT ERC20 contract, click "Write contract", you should end up here: https://etherscan.io/writecontract/index.html?m=normal&v=20.8.4.2&a=0xdac17f958d2ee523a2206206994597c13d831ec7&n=mainnet#collapse2 Click the "Connect with web3" link in the upper left corner to connect Metamask. Find the For "_spender (address)" enter Click "Write". Check the Metamask transaction details. They should be If Metamask asks you whether you want to permit Etherscan to spend your USDT, as it did for me, double check the transaction details. If they are like above, you are fine and you will be approving Uniswap v2 router and not Etherscan. Double check the fee Metamask is offering, it said ~$140 for me. The Click "Confirm". Once your transaction is confirmed you can go back to Uniswap and go ahead with the approval process there. |
Bug Description
Clicking on Approve does nothing. It does not bring up Metamask to proceed with the approval.
Steps to Reproduce
I am not sure how to reproduce this, but I've noticed this doesn't happen for all my addresses. Some work. This address in particular I've used with Uniswap many times before and probably already approved USDT up to some amount (maybe to infinity, maybe not). So my theory is that sometimes the interface doesn't correctly recognize the state of approval that already exists, yet it also does not decide a new approval is needed, thus leaving me stuck and unable to exchange USDT for ETH.
Expected Behavior
I expect the click to the button to bring up Metamask and ask me to confirm the approval transaction. I'm pretty sure I already approved to infinity before, but I'm OK doing it again. I just need to be allowed to do it.
Additional Context
Everything looks normal. I've got plenty USDT. But clicking on the Approve button does nothing.
The text was updated successfully, but these errors were encountered: