Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrum missing price impact and USD value #2492

Closed
willhennessy opened this issue Oct 4, 2021 · 1 comment · Fixed by #2630
Closed

Arbitrum missing price impact and USD value #2492

willhennessy opened this issue Oct 4, 2021 · 1 comment · Fixed by #2630
Assignees
@moodysalem
Labels
arbitrum Arbitrum network related bug Something isn't working p0 Very important to fix

Comments

@willhennessy
Copy link
Contributor

Bug Description
On Arbitrum network, the input and output field are missing their USD values. The output field is also missing the price impact.

Steps to Reproduce

  1. Connect to arbitrum and enter any swap

Screen Shot 2021-10-03 at 10 05 14 PM

Expected: USD in bottom right corner of input and output, as seen on OE and L1
Screen Shot 2021-10-03 at 10 04 48 PM
@willhennessy willhennessy added bug Something isn't working p0 Very important to fix arbitrum Arbitrum network related labels Oct 4, 2021
@willhennessy
Copy link
Contributor Author

still reproducing. Justin is going to investigate this in the related issue: #2491

@willhennessy willhennessy assigned moodysalem and unassigned ianlapham Oct 18, 2021
@moodysalem moodysalem mentioned this issue Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moodysalem moodysalem

Labels
arbitrum Arbitrum network related bug Something isn't working p0 Very important to fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: split calls into more chunks if they fail due to out of gas errors Uniswap/interface
4 participants
@willhennessy @JFrankfurt @moodysalem @ianlapham