-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert to commonjs #3373
fix: convert to commonjs #3373
Conversation
This pull request is being automatically deployed with Vercel (learn more). widgets – ./🔍 Inspect: https://vercel.com/uniswap/widgets/G9UZL3UPxSM16bnJQt9u2gq2KsRM interface – ./🔍 Inspect: https://vercel.com/uniswap/interface/6eGbNUrmnHHCsnSa9PHQNxzgeaTG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the deal with the vibrant changes?
Should we export both cjs and esm in the future, esm resolution requires that cjs modules be fully specified, so the vibrant imports will need to include an extension. See https://nodejs.org/api/esm.html#mandatory-file-extensions. This is an artifact of my first working to fix esm before abandoning it for cjs (due to too many upstream deps incorrectly supporting esm). I left it in because it is strictly more correct, and may save a headache in the future. |
Includes pinning exact @web3-react versions which support cjs