Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert to commonjs #3373

Merged
merged 6 commits into from
Feb 28, 2022
Merged

fix: convert to commonjs #3373

merged 6 commits into from
Feb 28, 2022

Conversation

zzmp
Copy link
Contributor

@zzmp zzmp commented Feb 26, 2022

Includes pinning exact @web3-react versions which support cjs

@vercel
Copy link

vercel bot commented Feb 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widgets – ./

🔍 Inspect: https://vercel.com/uniswap/widgets/G9UZL3UPxSM16bnJQt9u2gq2KsRM
✅ Preview: https://widgets-git-fix-cjs-uniswap.vercel.app

interface – ./

🔍 Inspect: https://vercel.com/uniswap/interface/6eGbNUrmnHHCsnSa9PHQNxzgeaTG
✅ Preview: https://interface-git-fix-cjs-uniswap.vercel.app

Copy link
Contributor

@JFrankfurt JFrankfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the deal with the vibrant changes?

@zzmp
Copy link
Contributor Author

zzmp commented Feb 27, 2022

What's the deal with the vibrant changes?

Should we export both cjs and esm in the future, esm resolution requires that cjs modules be fully specified, so the vibrant imports will need to include an extension. See https://nodejs.org/api/esm.html#mandatory-file-extensions.

This is an artifact of my first working to fix esm before abandoning it for cjs (due to too many upstream deps incorrectly supporting esm). I left it in because it is strictly more correct, and may save a headache in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants