Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: second user model PR with wallet properties #4206

Merged
merged 23 commits into from
Aug 3, 2022
Merged

feat: second user model PR with wallet properties #4206

merged 23 commits into from
Aug 3, 2022

Conversation

lynnshaoyu
Copy link
Contributor

@lynnshaoyu lynnshaoyu commented Jul 28, 2022 •
edited

  1. User model changes on wallet update:
    Screen Shot 2022-08-01 at 12 53 47 PM

Screen Shot 2022-07-29 at 2 59 44 PM

  1. App loaded event and initial screen /browser related data:
    Screen Shot 2022-07-29 at 4 58 49 PM

@vercel
Copy link

vercel bot commented Jul 28, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interface ✅ Ready (Inspect) Visit Preview Sep 3, 2022 at 0:18AM (UTC)

@lynnshaoyu lynnshaoyu requested a review from cmcewen July 28, 2022 15:22
@lynnshaoyu lynnshaoyu changed the base branch from main to WEB-623-time-event-properties-for-swap-events July 28, 2022 16:51
@lynnshaoyu lynnshaoyu requested a review from vm July 28, 2022 17:14
Base automatically changed from WEB-623-time-event-properties-for-swap-events to main July 28, 2022 19:35
@lynnshaoyu lynnshaoyu marked this pull request as ready for review August 1, 2022 17:01
@vm vm self-requested a review August 2, 2022 03:04
vm
vm reviewed Aug 2, 2022
View reviewed changes
src/pages/App.tsx Outdated Show resolved Hide resolved
vm
vm reviewed Aug 2, 2022
View reviewed changes
src/pages/App.tsx Show resolved Hide resolved
@lynnshaoyu lynnshaoyu requested review from vm and cartcrom August 2, 2022 23:36
@lynnshaoyu lynnshaoyu marked this pull request as draft August 2, 2022 23:49
@lynnshaoyu lynnshaoyu removed the request for review from cmcewen August 3, 2022 00:00
@lynnshaoyu lynnshaoyu marked this pull request as ready for review August 3, 2022 00:19
vm
vm approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@vm vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the native stuff, will leave that to your discretion.

@lynnshaoyu lynnshaoyu merged commit ed5902a into main Aug 3, 2022
@lynnshaoyu lynnshaoyu deleted the WEB-262-rest-of-user-model branch August 3, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vm vm vm approved these changes

@JFrankfurt JFrankfurt Awaiting requested review from JFrankfurt

@cartcrom cartcrom Awaiting requested review from cartcrom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lynnshaoyu @vm