fix: Add ETH to the floor price in trending collections banner. #5194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
unipadmini
requested review from
a team and
JFrankfurt
and removed request for
a team
vm
approved these changes
Nov 14, 2022
| @@ -164,15 +164,15 @@ const TableElement = styled.div` | |||
|
|
|||
| interface MarketplaceRowProps { | |||
| marketplace: string | |||
| floor?: string | |||
| floorInEth?: string | |||
There was a problem hiding this comment.
feels like we should be taking numbers here rather than strings? they would render properly
There was a problem hiding this comment.
the variable name change doesn't seem necessary but up to you on that
There was a problem hiding this comment.
tried to minimize change footprint as I'm learning the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "ETH" at the end of floor prices for trending collections in the explore banner.
Hardcoded ETH for now and included a small variable name change to make the logic more explicit and as a quick reminder that we'll need to change that logic if we want to be more flexible with floor price displays in the future.
Fixes https://uniswaplabs.atlassian.net/browse/WEB-2141