Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not attempt to cache i18n:extract #6616

Merged
merged 1 commit into from
May 22, 2023
Merged

fix: do not attempt to cache i18n:extract #6616

merged 1 commit into from
May 22, 2023

Conversation

zzmp
Copy link
Contributor

@zzmp zzmp commented May 22, 2023

Description

Removes the buggy caching layer for i18n:extract, to allow translation messages to be correctly extracted.

Slack thread: https://uniswapteam.slack.com/archives/C02T729PMQE/p1684776627955079?thread_ts=1684775215.278659&cid=C02T729PMQE

Test plan

Reproducing the error

  1. Run the caching extractor locally, verify that it incorrectly strips message headers
  2. Run the new non-caching extractor, verify that message headers are still there

@zzmp zzmp requested review from cmcewen and grabbou May 22, 2023 17:50
@zzmp zzmp temporarily deployed to false May 22, 2023 17:50 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 17:50 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 7:43pm
interface-node18 🛑 Canceled (Inspect) May 22, 2023 7:43pm

@zzmp zzmp temporarily deployed to false May 22, 2023 17:50 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 17:50 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 17:57 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 17:57 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 17:57 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 17:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -39.07 ⚠️

Comparison is base (f3a80c6) 60.18% compared to head (c1a1ecb) 21.11%.

❗ Current head c1a1ecb differs from pull request most recent head ef45a73. Consider uploading reports for the commit ef45a73 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6616       +/-   ##
===========================================
- Coverage   60.18%   21.11%   -39.07%     
===========================================
  Files         719      705       -14     
  Lines       21143    20827      -316     
  Branches     6974     6932       -42     
===========================================
- Hits        12724     4397     -8327     
- Misses       8342    16415     +8073     
+ Partials       77       15       -62     
Flag Coverage Δ
e2e-tests ?
unit-tests 21.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 431 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented May 22, 2023

Passing run #11202 ↗︎

0 69 8 0 Flakiness 0

Details:

fix: do not attempt to cache i18n:extract
Project: Uniswap Interface Commit: ef45a73615
Status: Passed Duration: 04:41 💡
Started: May 22, 2023 8:57 PM Ended: May 22, 2023 9:02 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@zzmp zzmp temporarily deployed to false May 22, 2023 19:28 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 19:28 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 19:28 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 19:28 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 19:29 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 19:29 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 19:29 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 19:29 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 20:54 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 20:54 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 20:54 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 20:54 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 20:54 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 20:54 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 20:54 — with GitHub Actions Inactive
@zzmp zzmp temporarily deployed to false May 22, 2023 20:54 — with GitHub Actions Inactive
@zzmp zzmp merged commit d28a4b3 into main May 22, 2023
35 of 36 checks passed
@zzmp zzmp deleted the fix-i18n-extract branch May 22, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants