-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not attempt to cache i18n:extract #6616
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6616 +/- ##
===========================================
- Coverage 60.18% 21.11% -39.07%
===========================================
Files 719 705 -14
Lines 21143 20827 -316
Branches 6974 6932 -42
===========================================
- Hits 12724 4397 -8327
- Misses 8342 16415 +8073
+ Partials 77 15 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Passing run #11202 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Description
Removes the buggy caching layer for i18n:extract, to allow translation messages to be correctly extracted.
Slack thread: https://uniswapteam.slack.com/archives/C02T729PMQE/p1684776627955079?thread_ts=1684775215.278659&cid=C02T729PMQE
Test plan
Reproducing the error