fix: Simplify event logging for SWAP_QUOTE_RECEIVED #6628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tinaszheng
commented
May 23, 2023
| ]) | ||
| if (!trade || prevTrade === trade) return // no new swap quote to log | ||
|
|
||
| setSwapQuoteReceivedDate(new Date()) |
There was a problem hiding this comment.
this property is still used downstream in child components, so not getting rid of it for now
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6628 +/- ##
==========================================
+ Coverage 58.76% 60.09% +1.32%
==========================================
Files 720 721 +1
Lines 21172 21166 -6
Branches 6981 6976 -5
==========================================
+ Hits 12442 12719 +277
+ Misses 8657 8370 -287
- Partials 73 77 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmcewen
approved these changes
May 23, 2023
1 flaky tests on run #11235 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Swap > Swap on main page > swaps ETH for USDC |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
lynnshaoyu
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous version of the hook was infinite looping when
tradeis always defined, so simplify logic to just keep track oftradechanges. Also removes the time-based logging since we have stats on the backend nowScreen capture
No UI changes
Test plan
Reproducing the error
Throw in a console.log right before
sendAnalyticsEventand see it firing like 1 million times lol