Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add infura url for base and base goerli #6976

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Conversation

cbachmeier
Copy link
Contributor

@cbachmeier cbachmeier commented Jul 18, 2023

Description

  • add infura url for base and base goerli to RPC_URLs
  • fixes bug where uniwallet could not connect

Slack thread: https://uniswapteam.slack.com/archives/C03NZGRTS3A/p1689721285990569

Screen capture

After

Screenshot 2023-07-18 at 4 30 59 PM

@cbachmeier cbachmeier requested a review from zzmp July 18, 2023 23:21
@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 11:33pm

src/constants/networks.ts Outdated Show resolved Hide resolved
src/constants/networks.ts Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Jul 18, 2023

1 flaky tests on run #12815 ↗︎

0 89 6 0 Flakiness 1

Details:

fix: add infura url for base and base goerli
Project: Uniswap Interface Commit: 25938d4133
Status: Passed Duration: 05:42 💡
Started: Jul 18, 2023 11:38 PM Ended: Jul 18, 2023 11:44 PM
Flakiness  cypress/e2e/swap/swap.test.ts • 1 flaky test • e2e

View Output Video

Test Artifacts
Swap > Swap on main page > swaps ETH for USDC Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cbachmeier cbachmeier merged commit 0904399 into releases/prod Jul 18, 2023
14 checks passed
@cbachmeier cbachmeier deleted the cab/base_infura branch July 18, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants