New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible optimizations by avoiding `extcodesize` #292

Open

shuhuiluo opened this issue May 9, 2023 · 0 comments

Contributor

shuhuiluo commented May 9, 2023

Consider using low level call or inline assembly for calling balanceOf, ownerOf, getReserves, swap, etc.

For example for command BALANCE_CHECK_ERC20,

universal-router/contracts/base/Dispatcher.sol

Lines 203 to 204 in b01e71f

    
           success = (ERC20(token).balanceOf(owner) >= minBalance); 
        
           if (!success) output = abi.encodePacked(BalanceTooLow.selector);

it isn't necessary to invoke extcodesize by using the interface. This also applies to all calls made to PERMIT2.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment