Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide comment for obscure mathing. #36

Closed
MicahZoltu opened this issue Dec 27, 2019 · 1 comment
Closed

Provide comment for obscure mathing. #36

MicahZoltu opened this issue Dec 27, 2019 · 1 comment

Comments

@MicahZoltu
Copy link

https://github.com/Uniswap/uniswap-v2-core/blob/d2ddbd95e8500cfd3669ab81b64f48956521ea6b/contracts/UniswapV2.sol#L55-L61

This is another place where commentary would be immensely valuable. The math being done here is sufficiently obscure to make it opaque to the reader what is actually happening here and, most importantly, why it is happening. This is obviously not a naive implementation, which is OK if there is a good reason for it to not be a naive implementation, but without any comments it just looks like an engineer being clever, and clever engineers are Bad™.

@NoahZinsmeister
Copy link
Contributor

closed by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants