Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong TVL of ETH, very large gap with etherscan, in USDC/ETH, WBTC/ETH #186

Open
tczpl opened this issue Nov 25, 2021 · 1 comment
Open
Labels
bug Something isn't working

Comments

@tczpl
Copy link

tczpl commented Nov 25, 2021

Bug Description
The TVL of ETH in v3-info is wrong in many pools.
For example, there is a very large gap between the TVL of ETH in v3-info with the real value in the WETH contract, e.g., USDC/ETH (45000 ETH in v3-info vs 28000 ETH in real),
It not only shows in the current data, but also shows in the historical TVLs.
We find this bug during processing historical data of v3. And we can easily confirm it through etherscan as follows.

Steps to Reproduce

  1. Go to the homepage of v3-info. We can find that the USDC/ETH and WBTC/ETH are the two most popular pools (highest TVL). Then click into the page of pool.
  2. Copy the contract address of the pool, then find it on etherscan. We can find the actual contracts: https://etherscan.io/address/0x8ad599c3a0ff1de082011efddc58f1908eb6e6d8, and https://etherscan.io/address/0xcbcdf9626bc03e24f779434178a73a0b4bad62ed.
    However, the TVLs of ETH are not as the same as they are on etherscan. Unfortunately, there is a large gap, as the following screenshots.
    image
    image
  3. If we use the balanceOf function to read the actual value in the WETH contract, it also shows much less than v3-info, in USDC/ETH, as follows.
    image
    We check the latest transactions, there are no transactions to cause such large gap significantly.
    Therefore, v3-info could be wrong in the TVL of WETH.
    There might be some other wrong TVLs, but we think WETH is the most urgent one with popular pools, which are displayed here.
    ...

Expected Behavior
Maybe processing the historical data again on an archived node (to call balanceOf) will fix this bug.

@Rachel-Eichenberger
Copy link

Rachel-Eichenberger commented Feb 4, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants