Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usepermit should return not_applicable if wallet doesnt support signtypeddata_v4 #624

Open
sirpy opened this issue Oct 24, 2023 · 2 comments

Comments

@sirpy
Copy link

sirpy commented Oct 24, 2023

For wallet connect it is possible to check the returned supported methods, maybe it is possible to verify for other wallets in some other way

maybe also allow the dev embedding the widget to force usage of approve

@sirpy
Copy link
Author

sirpy commented Jul 23, 2024

anyone?

@sirpy
Copy link
Author

sirpy commented Jul 23, 2024

with a wallet that doesnt support it, swapping works fine on app.uniswap.org but doesnt work with the widget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant