Memory leak on cluster mode for sails js

[shumailarshad]

I have created a new sails js app and did not change any code in it.

Than I used pm2 to launch two instance of that app. Memory keep increasing without hitting app even once.

I have done the same with basic express.js app with following code but it does not increase memory

"
var express = require('express');
var app = express();

app.get('/', function (req, res) {
res.send('Hello World!');
});

var server = app.listen(3000, function () {
var host = server.address().address;
var port = server.address().port;

console.log('Example app listening at http://%s:%s', host, port);
});
"
After around 2 - 3 hrs.. It comes up to:

After leaving it overnight.. It comes up to:

[soyuka]

How is this related to pm2?

[shumailarshad]

And when I use fork mode, it did not increase alot and stayed more steady.

[shumailarshad]

I am not sure but it only happens on cluster mode not fork mode (standalone sails app)

[soyuka]

So? No memory leak with express in cluster mode? Conclusion: it should be related to sails.

[jshkurti]

Which version of Node.js and Sails exactly ?
I would like to reproduce this bug.
Also a sample code would be nice.

Thanks for reporting this @shumailarshad

[jshkurti]

Bug confirmed. Inspecting this

[shumailarshad]

That is not problem. Please do let me know if you need any help in fixing this bug or any other.

Also, if you need to any more testing on my side, please do let me know.

[shumailarshad]

So I didn't write single line of code. Just did
sails new sailsApp
pm2 start app.js -i 2 --name "sailsApp"

[jshkurti]

Yep thanks. I managed to reproduce it. sails new project; cd project; pm2 start app.js -i 2.
The strange part about it, it's that you don't even have to perform requests with tools like ab or wrk. It just leaks even without ever hitting http://localhost:1337

[soyuka]

balderdashy/sails#3099

[shumailarshad]

Just to add. As @soyuka mentioned that issue I opened with sails. It seems to behave correctly if we turn off sockets, pubsub in .sailsrc file. But I still don't understand cause of the issue.

[soyuka]

I've done a few tests with express, sails and a basic http server :

Basic http server :

Express server :

Sails server :

Sails seems to be clearly leaking.

More infos : https://github.com/soyuka/nodejs-http-memtest

[soyuka]

Closing as a non-pm2 issue

[jshkurti]

Great work @soyuka 👍