Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipenv? #234

Closed
trondhindenes opened this issue Sep 8, 2018 · 2 comments
Closed

Support pipenv? #234

trondhindenes opened this issue Sep 8, 2018 · 2 comments

Comments

@trondhindenes
Copy link

trondhindenes commented Sep 8, 2018

It would be awesome to see this package supporting pipenv (https://pipenv.readthedocs.io/en/latest/). We're switching all our repos from simple requirements.txt to pienv because of the increased control, especially with the implementation of a lockfile. We're also using some internal and some external packages, and pipenv allows us to specify sources and link packages to sources.

Without having looked at the code for the serverless-python-requirements repo I have a feeling that it wouldn't take too much work to support pipenv. If there's interest I can check if I'm able to convince a few of the node/js devs on my team to help out.

@dschep
Copy link
Collaborator

dschep commented Sep 8, 2018

How hard did you look? 😛

It already supports pipenv: https://github.com/UnitedIncome/serverless-python-requirements#pipenv-support-sparklescakesparkles

@dschep dschep closed this as completed Sep 8, 2018
@trondhindenes
Copy link
Author

Now I feel stupid. Thanks, this is awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants