Broken @material-ui dependency?

[ArcticTee]

Hi, I am trying to include your Component in a React project of mine.

Running "@material-ui/core": "^4.3.1",

Getting the following errors:

./node_modules/react-image-annotate/Theme/index.js
Module not found: Can't resolve '@material-ui/core/styles/MuiThemeProvider' in '.../node_modules/react-image-annotate/Theme'

When I go back to a Version 3.9.3 of @material-ui the MuiThemeProvider is found.
But the @material-ui/lab/Slider dependency from material-survey will be lost.

Can't resolve '@material-ui/lab/Slider' in '.../node_modules/material-survey/components/RatingQuestion'

Or it may be related to this

Any suggestions?

[oliviertassinari]

Sorry for the trouble, does the import come from the auto-import feature of your IDE?
I would encourage the following:

-import { makeStyles } from "@material-ui/core/styles"
-import createMuiTheme from "@material-ui/core/styles/createMuiTheme"
-import MuiThemeProvider from "@material-ui/core/styles/MuiThemeProvider"
+import {
+  makeStyles,
+  createMuiTheme,
+  MuiThemeProvider,
+} from "@material-ui/core/styles"

These are private imports.

https://github.com/waoai/react-image-annotate/blob/fd8eb7e87cc1bb609a548e167e80d683bfa0dfc0/src/Theme/index.js#L5-L6

[ArcticTee]

Edited: I guess the fix for your Theme would work.

[oliviertassinari]

What do you mean by

@ArcticTee Sorry, it was a question for the author of the package.

This could be a potential workaround: mui/material-ui#17900 (comment).

[ArcticTee]

@oliviertassinari Sorry, confused you with the author or contributors of this package😂

[oliviertassinari]

Your best workaround is to freeze @material-ui/core to v4.5.0.

[ArcticTee]

I solved it by using

    "@material-ui/core": "4.4.0",
    "@material-ui/lab": "4.0.0-alpha.22",

in my package.json

[seveibar]

@ArcticTee thanks for reporting, assigning myself to fix this issue.

[oliviertassinari]

Notice that Material-UI v4.5.2 will soon come out with a warning instead of an exception for the import of this private module.

[seveibar]

fixed in 0.1.28