Cognito import from assets feature #415
Conversation
CedricProfessionnel
force-pushed
the
CognitoImportFromAssetsFeature
branch
7 times, most recently
from
310e7ec
to
46e64e7
Compare
There was a problem hiding this comment.
The most important thing to fix is to avoid loading in the full dataset unless you absolutely have to. The Import dialog isn't rendered conditionally but uses useDataset, so you're actually loading in the dataset anywhere where it's rendered, which will delays and extra bandwidth for people even if they're not using s3
|
You'll want to take a look at this line and make it conditional to easily fix that there are other fixes, for example, just not using the |
CedricProfessionnel
force-pushed
the
CognitoImportFromAssetsFeature
branch
from
46e64e7
to
c8bb196
Compare
CedricProfessionnel
force-pushed
the
CognitoImportFromAssetsFeature
branch
from
c8bb196
to
1317713
Compare
|
@CedricProfessionnel is this ready to review again? I see that I'm a pending reviewer but there's also one change requested so I'm not sure |
Yes, it is. |
| /> | ||
| ) : ( | ||
| <p></p> | ||
| )} |
There was a problem hiding this comment.
one thing you'll notice is that dialog animations for closing won't work now, but this is a small price to pay for the ease of dev
|
NICE WORK!!!!!!!!! |
## [0.14.18](v0.14.17...v0.14.18) (2021-01-14) ### Bug Fixes * Merge pull request [#415](#415) from CedricProfessionnel/CognitoImportFromAssetsFeature ([071c739](071c739))
|
🎉 This PR is included in version 0.14.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Enable the import from assets