New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UMS.deny feature was broken #2327
Comments
Yes we have an issue at #1801 after we had some comments last year about it being removed #1623 (comment) If you have time maybe you could look at reverting that change to bring it back? |
As I've explained before somewhere, this was removed from DMS because the implementation was problematic. Since I didn't think it was a frequently used feature, I simply removed it until it could be replaced by a better implementation some time in the future. The "problem" is rather that you didn't check what you cherry-picked from DMS. |
[post removed] |
@SubJunk I got the impressions that you weren't aware of this when you merged it the last time this was discussed. There are also many examples of other things that you've merged only to reverse them later, so it's a bit hard for me to believe that you had gone through what you cherry-picked. That said, if you claim that you knew this and still went ahead, I certainly shouldn't feel the need to explain. In the end it's your responsibility whether you knew about it or not. |
@valib are you interested in doing that reversion? I have a few other things I'm working on in UMS so that would be helpful if you could do it |
@SubJunk I am on holiday so I will check it after New Year's Eve. |
I'm interested in doing this now that we have the web GUI. I'm starting now |
@SubJunk this is reported in https://www.universalmediaserver.com/forum/viewtopic.php?f=9&t=14510 and was broken in the PR 91bc9a6 means that either the DMS denies this feature or certainly it was moved somewhere and not properly merged. But we both didn't realized the problem.
The text was updated successfully, but these errors were encountered: