New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marking media played entirely #3947
Comments
Could you post your logs? See here for instructions. |
Hello, attached the UMS logs |
Nothing was playing when you created the logs so could not see anything. Could you try again but fully watch something from your renderer so I can see what UMS does. It may be enough to skip to near the end of the video. |
Hello, I played some video until the next video loaded, but they are still marked as fully played. |
Not sue what is going on. I see the fully played logging and from what I understand it should be marking them as played but is not. I tried to see if it was a configuration problem but I see you don't have the advanced options enabled so you would not have changed anything. I have mine set to move fully played videos to another folder and it still works for me. Go into settings and enable If this now works then the default option must have changed somehow, maybe on accident or due to a bug (possibly related to #3948) |
I have already reinstalled the software with all the default settings (Clean install), after a test the media was still not marked. In link some images of the general parameters of UMS: |
Since you did a clean install could you do some more logs with your new settings? |
The last logs that I provided to you were made after the new installation (Clean install), I just deactivated the Media Library virtual folder, Played recently, TRANSCODE, I had done another test without touching any parameters (UMS By default), the media played entirely was not marked |
I tried to replicate this on my system using your settings and at first I could not reproduce this behaviour, then it stopped marking. I messed around with the settings to enable and disable cache, marking, and media library by editing your conf to add those options. The results were random, sometimes working and other not and I could not pin it down to anything specific. I also tried with videos streamed and transcoded. An example of this happening is
While this is when it works (set to move on fully played)
Odd thing is when I restored my original conf I had one file that I was testing with to refuse to mark. This suggests that there could be something wrong with the data for that file in the database. Once I removed that file from the shared folder then re-added it it worked as normal. This would make sense as the entry in the database will be remade. @SubJunk in the fully played logging there the message |
Hello, UMS 13.5.0 still does not mark the media fully played, the problem still persists to this day, attached the UMS log |
@Fredo1650 hi, I can see in your logs that the video was stopped too soon for us to consider it full played. You stopped it at |
Hello, I followed your @SubJunk advice and thank you, but that didn't change the problem, the media are still not marked. TRACE 2023-08-20 22:34:18.876 [StopPlaying Event] net.pms.dlna.MediaMonitor Fully Played feature logging: |
Hello, in this photo attached a description of the problem on another series, the episodes are fully played passing one after the other, there were no stops, only 3 episodes are marked. Can you help me fix this untagged multimedia bug? Episode 4: Episode 5: |
I see what is happening. In the background, the TV is sending a request for the end of the video before it is finished. From the logs, there are 4 requests for that video that happen: 1:
2:
3:
4:
which is annoying because it breaks my logic for another fix. I'll have to think about how to fix this |
I have a possible fix, can you please test it? |
Hello @SubJunk I have just read several episodes, it works correctly for the moment with the version that you modified on the previous post, the episodes have all been marked. Below the latest UMS logs after the correction |
@Fredo1650 thank you for the fast testing, and for reporting the bug. Yes this will make it into the release after 13.6.0 |
Hello, since the 13.4.0 update the fully played media are no longer marked, software bug? , Can you help me ?
The text was updated successfully, but these errors were encountered: