Added interface for forwarding script commands to the robot, that is … #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauch
reviewed
Sep 20, 2022
There was a problem hiding this comment.
In general seems very clean. Tested together with UniversalRobots/Universal_Robots_ROS_Driver#567 and works fine.
Not approving because of a couple of discussion points left.
…then executed locally on the robot This allows the user to be able to zero ftsensor, set payload and set tool voltage when the robot is in local control.
Co-authored-by: Felix Exner <felix_mauch@web.de>
… throwing an exception
urmahp
force-pushed
the
script_commands
branch
from
8b07dca
to
4334ae0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
=========================================
Coverage ? 40.35%
=========================================
Files ? 78
Lines ? 2166
Branches ? 265
=========================================
Hits ? 874
Misses ? 1179
Partials ? 113 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fmauch
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…then executed locally on the robot
This allows the user to be able to zero ftsensor, set payload and set tool voltage when the robot is in local control.