New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for the comm classes #129
Conversation
I will have to dig into why the consumer test is failing, as it hasn't been failing locally, so I am converting this PR to a draft for now. |
Codecov ReportBase: 74.59% // Head: 77.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 74.59% 77.45% +2.86%
==========================================
Files 89 95 +6
Lines 3491 3939 +448
Branches 368 385 +17
==========================================
+ Hits 2604 3051 +447
+ Misses 668 664 -4
- Partials 219 224 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d158019
to
eb740a0
Compare
I found the issue. Since the consumer is running in a thread sometimes the consumer wasn't started when the message was send to the client and therefore the test failed, this has been fixed with a retry mechanism, so the message is resend to the client if the first one wasn't consumed. |
bad8afc
to
2d985a9
Compare
This add tests for * bin parser * package serializer * TCP socket * stream * producer * pipeline Fixed check size in bin parser, so that it works with starndard data types Added recconection time variable to TCP socket, this will control the time in between connection attempts if the server is unavailable.
83d5a90
to
58b1d84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing the segfault in the pipeline test this seems fine. Thank you @urmahp
* Added tests for the comm classes This add tests for * bin parser * package serializer * TCP socket * stream * producer * pipeline Fixed check size in bin parser, so that it works with starndard data types Added recconection time variable to TCP socket, this will control the time in between connection attempts if the server is unavailable. Co-authored-by: Felix Exner <exner@fzi.de>
This add tests for
Fixed check size in bin parser, so that it works with starndard data types
Added recconection time variable to TCP socket, this will control the time in between connection attempts if the server is unavailable.