Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prerelease check that calls bloom-generate #134

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Nov 28, 2022

Since I had problems in the bloom-generate step when releasing 1.3.0 and similar things have happened in the past, I think it is a good idea to add a check to new PRs to prevent such things in the future.

This PR also contains a fix for the regression currently living on the master branch introduced in #127.

Copy link
Collaborator

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable approach

@RobertWilbrandt RobertWilbrandt merged commit 099b34f into master Nov 30, 2022
@RobertWilbrandt RobertWilbrandt deleted the testing/prerelease branch November 30, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants