Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed num_retries from static to an unsigned int #136

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

urmahp
Copy link
Collaborator

@urmahp urmahp commented Dec 28, 2022

The num_retries wouldn't be reset within each function, but it will now so the correct number of retries is performed in each function, before throwing an exception.

The num_retries wouldn't be reset within each function, but it will now so the correct number of retries is performed in each function, before throwing an exception.
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 74.09% // Head: 74.55% // Increases project coverage by +0.46% 🎉

Coverage data is based on head (31f2242) compared to base (09adab9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   74.09%   74.55%   +0.46%     
==========================================
  Files          91       89       -2     
  Lines        3462     3490      +28     
  Branches      359      367       +8     
==========================================
+ Hits         2565     2602      +37     
+ Misses        680      668      -12     
- Partials      217      220       +3     
Impacted Files Coverage Δ
src/rtde/rtde_client.cpp 55.97% <100.00%> (+1.67%) ⬆️
tests/test_primary_parser.cpp 81.81% <0.00%> (-8.19%) ⬇️
include/ur_client_library/comm/stream.h 88.88% <0.00%> (-7.12%) ⬇️
include/ur_client_library/rtde/rtde_writer.h 75.00% <0.00%> (-5.00%) ⬇️
tests/test_rtde_parser.cpp 80.45% <0.00%> (-3.45%) ⬇️
include/ur_client_library/queue/atomicops.h 66.66% <0.00%> (-3.08%) ⬇️
tests/test_rtde_client.cpp 80.85% <0.00%> (-0.68%) ⬇️
src/log.cpp 73.80% <0.00%> (-0.61%) ⬇️
src/control/script_command_interface.cpp 11.11% <0.00%> (-0.21%) ⬇️
src/ur/dashboard_client.cpp 61.22% <0.00%> (-0.16%) ⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @urmahp

@fmauch fmauch merged commit 1853580 into UniversalRobots:master Jan 5, 2023
@urmahp urmahp deleted the rtde_retry_var branch January 6, 2023 07:05
urrsk pushed a commit to urrsk/Universal_Robots_Client_Library that referenced this pull request Jun 28, 2023
The num_retries wouldn't be reset within each function, but it will now so the correct number of retries is performed in each function, before throwing an exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants