Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifically set RTDE pipeline producer to FIFO scheduling #139

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Jan 30, 2023

Regardless of the actual kernel used, setting the producer thread to FIFO scheduling seems to improve robustness.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Patch coverage: 70.45% and project coverage change: +0.01 🎉

Comparison is base (2e69bc1) 77.48% compared to head (0141342) 77.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   77.48%   77.49%   +0.01%     
==========================================
  Files          95       96       +1     
  Lines        3939     3959      +20     
  Branches      385      385              
==========================================
+ Hits         3052     3068      +16     
- Misses        662      667       +5     
+ Partials      225      224       -1     
Impacted Files Coverage Δ
include/ur_client_library/queue/atomicops.h 63.88% <ø> (-1.39%) ⬇️
src/helpers.cpp 50.00% <50.00%> (ø)
include/ur_client_library/comm/pipeline.h 71.91% <94.73%> (+6.31%) ⬆️
src/rtde/rtde_client.cpp 55.97% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Regardless of the actual kernel used, setting the producer thread to FIFO
scheduling seems to improve robustness.
@fmauch fmauch merged commit f170fcf into UniversalRobots:master Jun 26, 2023
18 of 19 checks passed
@fmauch fmauch deleted the scheduling_rtde_pipeline branch June 30, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants