Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install start ursim #155

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Jul 5, 2023

This PR installs the start_ursim script to the package's install space. This way, it can be reused in downstream packages such as the ROS drivers.

fmauch and others added 3 commits July 5, 2023 06:55
This way we can use it from the driver packages and don't have to duplicate code
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 78.43% and project coverage change: +1.07 🎉

Comparison is base (d5ac71a) 69.54% compared to head (687d276) 70.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   69.54%   70.62%   +1.07%     
==========================================
  Files          69       69              
  Lines        2476     2526      +50     
  Branches      314      321       +7     
==========================================
+ Hits         1722     1784      +62     
+ Misses        576      562      -14     
- Partials      178      180       +2     
Impacted Files Coverage Δ
...lient_library/control/trajectory_point_interface.h 100.00% <ø> (ø)
include/ur_client_library/ur/ur_driver.h 71.42% <ø> (+11.42%) ⬆️
src/ur/ur_driver.cpp 51.00% <50.00%> (+2.03%) ⬆️
src/control/trajectory_point_interface.cpp 77.21% <83.72%> (+5.42%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fmauch fmauch marked this pull request as draft July 6, 2023 04:39
@fmauch fmauch marked this pull request as ready for review July 6, 2023 05:01
@fmauch
Copy link
Collaborator Author

fmauch commented Jul 6, 2023

@fmauch fmauch added this to the Release 1.3.2 milestone Jul 6, 2023
Copy link
Collaborator

@RobertWilbrandt RobertWilbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a great step to remove these redundant files!

@RobertWilbrandt RobertWilbrandt merged commit a1e514c into UniversalRobots:master Jul 12, 2023
16 of 17 checks passed
@fmauch fmauch deleted the install_start_ursim branch July 13, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants