Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should fix the prerelease ci for Melodic #163

Merged

Conversation

urrsk
Copy link
Member

@urrsk urrsk commented Aug 4, 2023

No description provided.

@urrsk urrsk force-pushed the MakeMelodicPreReleaseCIWorkAgain branch from d51fecc to 330da89 Compare August 4, 2023 12:52
@urrsk urrsk requested a review from fmauch August 4, 2023 12:57
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.58% ⚠️

Comparison is base (692e274) 70.62% compared to head (330da89) 70.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   70.62%   70.05%   -0.58%     
==========================================
  Files          69       69              
  Lines        2526     2521       -5     
  Branches      322      321       -1     
==========================================
- Hits         1784     1766      -18     
- Misses        556      571      +15     
+ Partials      186      184       -2     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urrsk urrsk requested a review from urmahp August 4, 2023 13:38
@urrsk
Copy link
Member Author

urrsk commented Aug 4, 2023

Prerelease CI with melodic seems to be fixed. Suggest we merge even though the integration test is failing.
I expect that the intergration test is fixed by #162

Copy link
Collaborator

@urmahp urmahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@urrsk urrsk merged commit cf8c61d into UniversalRobots:master Aug 7, 2023
15 of 17 checks passed
@urrsk urrsk deleted the MakeMelodicPreReleaseCIWorkAgain branch August 7, 2023 09:16
@urrsk urrsk mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants