Only warn if system is not setup for FIFO scheduling #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 70.32% 70.33% +0.01%
==========================================
Files 69 69
Lines 2534 2535 +1
Branches 324 324
==========================================
+ Hits 1782 1783 +1
- Misses 563 565 +2
+ Partials 189 187 -2
☔ View full report in Codecov by Sentry. |
fmauch
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
From my memory we explicitly decided to make this an error as we wanted to emphasis that we expect things to go wrong when not using a PREEMPT_RT kernel. However, also from the experience I've collected over the years developing with a standard kernel without any special setup I agree that going to a warning seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on UniversalRobots/Universal_Robots_ROS_Driver#654
I agree that an error message seems too hard here, as you are still able to operate the driver even if you are not setup for FIFO scheduling. We also shouldn't error out twice, if we cannot change the scheduling parameters the second check seems redundant.