Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reverse_ip #52

Merged
merged 4 commits into from
May 31, 2021
Merged

add reverse_ip #52

merged 4 commits into from
May 31, 2021

Conversation

JS00000
Copy link
Contributor

@JS00000 JS00000 commented Apr 9, 2021

This PR is copied from here, which can help the socket in the UR's Teach Pendant know the host IP address when this library is running in the Docker container (especially in Docker for Windows).

@fmauch
Copy link
Collaborator

fmauch commented May 15, 2021

@JS00000 just letting you know: I haven't forgotten this, it#s just a lot of other things currently going on in the library. I'll address this once #65 is merged.

@fmauch
Copy link
Collaborator

fmauch commented May 25, 2021

@JS00000 could you please rebase this ontop of the current master? Or alternatively allow edits from maintainers for this PR, then I can push the changes I've done locally (resolving the conflicts) directly to your branch.

@JS00000
Copy link
Contributor Author

JS00000 commented May 26, 2021

@JS00000 could you please rebase this ontop of the current master? Or alternatively allow edits from maintainers for this PR, then I can push the changes I've done locally (resolving the conflicts) directly to your branch.

I have done that. And I realize that I need to clone ur_msgs and fetch the new calibration_devel of universal_robot to build the project successfully. There are a lot of changes.

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmauch fmauch changed the title add reserve_ip add reverse_ip May 31, 2021
@fmauch fmauch merged commit 04ac67c into UniversalRobots:master May 31, 2021
urmahp pushed a commit to urmahp/Universal_Robots_Client_Library that referenced this pull request Sep 5, 2022
Add reverse_ip parameter to UrDriver

This parameter enables users to specify the ip address (and hereby network interface) on which the reverse_port should be opened. This helps in some more complex setup such as things running in different docker containers.

Co-authored-by: Felix Exner <exner@fzi.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants