Removed console_bridge dependency #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As log handlers for the client library has been created in the drivers, the console bridge dependency is no longer needed.
|
At a first glimpse, this looks good. I'll postpone this until after the next release containing all the Cartesian features, alright? |
|
As both mentioned PRs are merged, I would go ahead and merge this. |
urmahp
added a commit
to urmahp/Universal_Robots_Client_Library
that referenced
this pull request
Sep 5, 2022
As log handlers for the client library has been created in the drivers, the console bridge dependency is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As log handlers for the client library has been created in the drivers, the console bridge dependency is no longer needed.
As a log handler has been created for the ROS2 Driver and the ROS Driver, the console bridge dependency is no longer needed. Also in order for the handlers to actually work, we need to build the client library without console bridge.
This shouldn't be merged before the two PR's UniversalRobots/Universal_Robots_ROS_Driver#398 and UniversalRobots/Universal_Robots_ROS2_Driver#126 has been merged