Added target_frequency to RTDEClient #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauch
reviewed
Aug 5, 2021
jornb
force-pushed
the
feat/target_frequency
branch
from
2853b97
to
555342e
Compare
|
Updated now based on previous review by @fmauch. I agree with the |
jornb
force-pushed
the
feat/target_frequency
branch
from
555342e
to
9bc14e2
Compare
fmauch
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
LGTM! Thanks @jornb
@stefanscherzinger if you agree, please go ahead and merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some scenarios, e.g. state monitoring, 500 Hz is overkill, and may lead to performance issues on some platforms or with multiple RTDE clients.
This PR adds a
target_frequencyargument to theRTDEconstructor, defaulting to the maximum frequency (i.e. 125 or 500).